Minor change to documentation of RAND_DRBG_set_defaults()#7326
Closed
slontis wants to merge 2 commits intoopenssl:masterfrom
Closed
Minor change to documentation of RAND_DRBG_set_defaults()#7326slontis wants to merge 2 commits intoopenssl:masterfrom
slontis wants to merge 2 commits intoopenssl:masterfrom
Conversation
InfoHunter
reviewed
Sep 28, 2018
doc/man3/RAND_DRBG_new.pod
Outdated
| @@ -84,8 +85,7 @@ Enables use of HMAC instead of the HASH DRBG. | |||
| These 3 flags can be used to set the individual DRBG types created. Multiple | |||
| calls are required to set the types to different values. If none of these 3 | |||
| flags are used, then the same type and flags are used for all 3 DRBG's in the | |||
Member
There was a problem hiding this comment.
I might find a nit outside your diff zone... Should this 3 DRBG's be 3 DRBGs?
InfoHunter
approved these changes
Sep 28, 2018
Member
InfoHunter
left a comment
InfoHunter
left a comment
There was a problem hiding this comment.
I think this PR addresses some latest reviews in #6779
InfoHunter
added
branch: master
paulidale
approved these changes
Sep 29, 2018
paulidale
added
approval: done
Contributor
|
@kroeckx any input on this one before it is merged? |
Member
|
Feel free to merge this
|
Contributor
|
Merged, thanks. |
levitte
pushed a commit
that referenced
this pull request
Oct 1, 2018
Minor change to documentation of RAND_DRBG_set_defaults() Reviewed-by: Paul Yang <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #7326)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist