CAPI engine: add support for RSA_NO_PADDING [master / 1.1.1, 1.1.0]#7174
Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
Closed
CAPI engine: add support for RSA_NO_PADDING [master / 1.1.1, 1.1.0]#7174levitte wants to merge 1 commit intoopenssl:masterfrom
levitte wants to merge 1 commit intoopenssl:masterfrom
Conversation
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became unusable. This change fixes that. Fixes openssl#7131
levitte
added
branch: master
mattcaswell
approved these changes
Sep 11, 2018
mattcaswell
added
the
approval: done
t-j-h
approved these changes
Sep 11, 2018
levitte
added a commit
that referenced
this pull request
Sep 11, 2018
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became unusable. This change fixes that. Fixes #7131 Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #7174) (cherry picked from commit 37f4928)
Member
|
Pushed. |
levitte
added a commit
that referenced
this pull request
Sep 11, 2018
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became unusable. This change fixes that. Fixes #7131 Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #7174)
| if (!CryptDecrypt(capi_key->key, 0, TRUE, flags, tmpbuf, &dlen)) { | ||
| CAPIerr(CAPI_F_CAPI_RSA_PRIV_DEC, CAPI_R_DECRYPT_ERROR); | ||
| capi_addlasterror(); | ||
| OPENSSL_cleanse(tmpbuf, dlen); |
Contributor
There was a problem hiding this comment.
Any reason for not using OPENSSL_clear_free() here rather than keeping OPENSSL_free() and adding an explicit OPENSSL_cleanse()?
| } else { | ||
| memcpy(to, tmpbuf, (flen = (int)dlen)); | ||
| } | ||
| OPENSSL_cleanse(tmpbuf, flen); |
Contributor
There was a problem hiding this comment.
Same comment here regarding use of OPENSSL_clear_free() rather than OPENSSL_cleanse()
Contributor
|
Sorry observation too late :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became
unusable. This change fixes that.
Fixes #7131
This is a port of #7132, which unfortunately didn't cherry-pick cleanly to master