Check the return value from ASN1_INTEGER_set#7169
Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Closed
Check the return value from ASN1_INTEGER_set#7169mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Conversation
Found by Coverity
mattcaswell
added
branch: master
Member
Author
|
It's not clear to me why Coverity only started displaying this now...its been like this for a long time. |
levitte
approved these changes
Sep 10, 2018
Member
|
Maybe Coverity got a nit-pick upgrade ;-) |
Member
Author
|
Well what's even stranger is that the "First detected" field lists this as having been found on 12th December 2014. But the "Triage history" only lists yesterday's date. I wonder if the reconfigure of the project settings (to list the test issues) for some reason kicked this out of limbo somewhere. |
Member
|
Possibly... could it be that someone marked it as a false positive a long time ago, and it got reset somehow now? |
Member
Author
|
Maybe... |
levitte
pushed a commit
that referenced
this pull request
Sep 10, 2018
Found by Coverity Reviewed-by: Richard Levitte <[email protected]> (Merged from #7169) (cherry picked from commit 512d811)
levitte
pushed a commit
that referenced
this pull request
Sep 10, 2018
Found by Coverity Reviewed-by: Richard Levitte <[email protected]> (Merged from #7169)
levitte
pushed a commit
that referenced
this pull request
Sep 10, 2018
Found by Coverity Reviewed-by: Richard Levitte <[email protected]> (Merged from #7169) (cherry picked from commit 512d811)
Member
Author
|
Pushed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by Coverity