Make the config script fail with an error code if Configure failed#7166
Closed
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Closed
Make the config script fail with an error code if Configure failed#7166bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
bernd-edlinger wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Conversation
bernd-edlinger
added
branch: 1.0.2
Member
|
Why not master / 1.1.1? |
Member
Author
|
master has "exit 1" here. |
Member
|
Ah, so this is essentially 141d732 being backported... I actually wonder why that one wasn't cherry-picked... |
levitte
approved these changes
Sep 10, 2018
levitte
pushed a commit
that referenced
this pull request
Sep 11, 2018
Reviewed-by: Richard Levitte <[email protected]> (Merged from #7166)
levitte
pushed a commit
that referenced
this pull request
Sep 11, 2018
Reviewed-by: Richard Levitte <[email protected]> (Merged from #7166) (cherry picked from commit e13dc23)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config needs to return an error if Configure fails.
We noticed this because:
"./config && make depend && make"
actually "worked" with perl 5.8.8 installed!
It was just odd, that it did not use gcc but cc...