CAPI engine: add support for RSA_NO_PADDING [1.0.2]#7132
Closed
levitte wants to merge 2 commits intoopenssl:OpenSSL_1_0_2-stablefrom
Closed
CAPI engine: add support for RSA_NO_PADDING [1.0.2]#7132levitte wants to merge 2 commits intoopenssl:OpenSSL_1_0_2-stablefrom
levitte wants to merge 2 commits intoopenssl:OpenSSL_1_0_2-stablefrom
Conversation
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became unusable. This change fixes that. Fixes openssl#7131
levitte
added
branch: master
| if (!CryptDecrypt(capi_key->key, 0, TRUE, flags, tmpbuf, &flen)) { | ||
| CAPIerr(CAPI_F_CAPI_RSA_PRIV_DEC, CAPI_R_DECRYPT_ERROR); | ||
| capi_addlasterror(); | ||
| OPENSSL_free(tmpbuf); |
Member
There was a problem hiding this comment.
tmpbuf will need a OPENSSL_cleanse (especially in the successful code path, of course)
levitte
changed the title
Member
Author
|
I took this out of WIP (had forgotten about that...) |
bernd-edlinger
approved these changes
Sep 10, 2018
t-j-h
approved these changes
Sep 11, 2018
Member
t-j-h
left a comment
t-j-h
left a comment
There was a problem hiding this comment.
The error handling code isn't particularly nice - but that isn't what you are changing in this PR so leaving that for later.
t-j-h
added
the
approval: done
Member
Author
|
This didn't cherry-pick cleanly up the releases, so there's a port in #7174 |
levitte
removed
1.1.0
branch: 1.1.1
levitte
added a commit
that referenced
this pull request
Sep 11, 2018
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became unusable. This change fixes that. Fixes #7131 Reviewed-by: Bernd Edlinger <[email protected]> Reviewed-by: Tim Hudson <[email protected]> (Merged from #7132)
Member
|
Pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the SSL code started using RSA_NO_PADDING, the CAPI engine became
unusable. This change fixes that.
Fixes #7131