document the -no_ecdhe option in s_server man page#7046
document the -no_ecdhe option in s_server man page#7046tomato42 wants to merge 1 commit intoopenssl:OpenSSL_1_0_2-stablefrom
Conversation
InfoHunter
left a comment
InfoHunter
left a comment
There was a problem hiding this comment.
Although I think ECDH could also use the term 'ECDH parameters' instead of 'ECDH curves'...
doc/apps/s_server.pod
Outdated
There was a problem hiding this comment.
I agree with @InfoHunter that this entry should replace curves with parameters, for coherence with the equivalent -no_dhe option.
There was a problem hiding this comment.
technically, the only parameter the server can select in ECDH is the curve – the base point is bound to the curve so is not selectable – in FFDH it's both the prime and the generator that is selectable and sent to the client so there are parameters (plural) in SKE
so for ECDH "curves" and "parameters" in this context are synonymous
the option is provided in the -help message of the s_server utility but it is not documented in the man page, this fixes it
|
@romen @InfoHunter updated |
InfoHunter
left a comment
InfoHunter
left a comment
There was a problem hiding this comment.
Re-approved due to the change of the code...
InfoHunter
added
the
approval: review pending
romen
left a comment
romen
left a comment
There was a problem hiding this comment.
LGTM. We now need approval from @openssl/omc
InfoHunter
added
approval: done
the option is provided in the -help message of the s_server utility but it is not documented in the man page, this fixes it Reviewed-by: Nicola Tuveri <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Paul Yang <[email protected]> (Merged from #7046)
|
thanks for quick turn-around :) |
4 participants
the option is provided in the
-helpmessage of thes_serverutilitybut it is not documented in the man page, this fixes it
Checklist