Clarify the EVP_DigestSignInit docs (1.0.2)#7043
Closed
mattcaswell wants to merge 2 commits intoopenssl:OpenSSL_1_0_2-stablefrom
Closed
Clarify the EVP_DigestSignInit docs (1.0.2)#7043mattcaswell wants to merge 2 commits intoopenssl:OpenSSL_1_0_2-stablefrom
mattcaswell wants to merge 2 commits intoopenssl:OpenSSL_1_0_2-stablefrom
Conversation
They did not make it clear how the memory management works for the |pctx| parameter.
t-j-h
approved these changes
Aug 23, 2018
Member
|
This has the required approvals. @mattcaswell I'd be happy to merge it given you are away. |
Member
|
Oh, actually I see there's an unaddressed comment in the original PR, so it's probably better to wait for this as well. |
Member
Author
|
Yes, its currently waiting on me updating the original PR, and then backporting that update to here. That's probably not going to happen this week. Thanks for the offer though. |
mattcaswell
force-pushed
the
clarify-digestsigninit-docs-102
branch
from
cafc09a to
de372b2
Compare
Member
Author
t-j-h
approved these changes
Sep 3, 2018
levitte
pushed a commit
that referenced
this pull request
Sep 4, 2018
They did not make it clear how the memory management works for the |pctx| parameter. Reviewed-by: Tim Hudson <[email protected]> (Merged from #7043)
Member
Author
|
Pushed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They did not make it clear how the memory management works for the |pctx|
parameter.
This is the 1.0.2 version of #7042.