Clarify the EVP_DigestSignInit docs#7042
Closed
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
Closed
Conversation
They did not make it clear how the memory management works for the |pctx| parameter. Fixes openssl#7037
mattcaswell
added
branch: master
t-j-h
approved these changes
Aug 23, 2018
Member
Author
|
See also #7043 for 1.0.2 version |
parasssh
reviewed
Aug 23, 2018
doc/man3/EVP_DigestSignInit.pod
Outdated
| @@ -26,8 +26,10 @@ EVP_DigestSignInit() sets up signing context B<ctx> to use digest B<type> from | |||
| ENGINE B<e> and private key B<pkey>. B<ctx> must be created with | |||
| EVP_MD_CTX_new() before calling this function. If B<pctx> is not NULL the | |||
Contributor
There was a problem hiding this comment.
nit:
While you are at it, need a comma after the word "NULL"
Contributor
|
@mattcaswell , you might want to edit the EVP_DigestVerifyInit() docs as well. |
Member
|
Note an issue with a 1.1.1 milestone referenced this PR so I added the 1.1.1 milestone to the PR to make it clear. If the issue gets reclassified then this PR should also |
mattcaswell
force-pushed
the
clarify-digestsigninit-docs
branch
from
c2c5063 to
1d28666
Compare
Member
Author
Member
Author
|
I removed the 1.1.1 milestone from the referencing issue, so I removed it from here too. |
t-j-h
approved these changes
Sep 3, 2018
levitte
pushed a commit
that referenced
this pull request
Sep 4, 2018
They did not make it clear how the memory management works for the |pctx| parameter. Fixes #7037 Reviewed-by: Tim Hudson <[email protected]> (Merged from #7042) (cherry picked from commit f097e87)
Member
Author
|
Pushed to master and 1.1.0. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Sep 4, 2018
They did not make it clear how the memory management works for the |pctx| parameter. Fixes #7037 Reviewed-by: Tim Hudson <[email protected]> (Merged from #7042)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They did not make it clear how the memory management works for the |pctx|
parameter.
Fixes #7037