Allow empty message in 448 sign.#6817
Closed
richsalz wants to merge 1 commit intoopenssl:masterfrom
richsalz:gh6800
Closed
Allow empty message in 448 sign.#6817richsalz wants to merge 1 commit intoopenssl:masterfrom richsalz:gh6800
richsalz wants to merge 1 commit intoopenssl:masterfrom
richsalz:gh6800
Conversation
Thanks to GitHub user Bugcheckers for reporting this.
richsalz
added
branch: master
paulidale
added
approval: done
Contributor
Author
|
I think moving it to the EVP layer makes sense and am closing this. I don't think "hash of zero data" is reasonable or expected by openssl users. |
mspncp
added a commit
to mspncp/openssl
that referenced
this pull request
Aug 4, 2018
The majority of callers does not check for an empty buffer (buffer_length == 0) before calling EVP_Digest*Update(), because all implementations handle this case correctly as no-op. (See discussions in openssl#6800, openssl#6817, and openssl#6838.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to GitHub user Bugcheckers for reporting this.
Fixes #6800