apps/speed: fix possible OOB access in some EC arrays (1.1.0)#6245
Closed
FdaSilvaYY wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Closed
apps/speed: fix possible OOB access in some EC arrays (1.1.0)#6245FdaSilvaYY wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
FdaSilvaYY wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Conversation
Contributor
Author
|
As #6133 don't cherry-pick cleanly, I have to do some adjustments ;) |
FdaSilvaYY
force-pushed
the
1-1-0-backport
branch
from
b316e08 to
b397e79
Compare
Contributor
Author
dot-asm
reviewed
May 15, 2018
apps/speed.c
Outdated
Contributor
There was a problem hiding this comment.
While we are at it, I'd suggest to fix formatting as
typedef void *(*kdf_fn)(const void *in, size_t inlen, void *out,
size_t *xoutlen);
c6c5126 to
9f36894
Compare
because there are actually 17 curves defined, but only 16 are plugged for ecdsa test. Deduce array size using OSSL_NELEM and so remove various magic numbers, which required some declarations moving. Implement OPT_PAIR list search without a null-ending element. Fix some comparison between signed and unsigned integer expressions. cherry-picking from commit 5c6a69f. Partial Back-port of openssl#6133 to 1.1.0
FdaSilvaYY
force-pushed
the
1-1-0-backport
branch
from
9f36894 to
7a4a7e7
Compare
dot-asm
approved these changes
May 15, 2018
dot-asm
added
1.1.0
approval: review pending
richsalz
approved these changes
May 15, 2018
richsalz
added
approval: done
levitte
pushed a commit
that referenced
this pull request
May 18, 2018
because there are actually 17 curves defined, but only 16 are plugged for ecdsa test. Deduce array size using OSSL_NELEM and so remove various magic numbers, which required some declarations moving. Implement OPT_PAIR list search without a null-ending element. Fix some comparison between signed and unsigned integer expressions. cherry-picking from commit 5c6a69f. Partial Back-port of #6133 to 1.1.0 Reviewed-by: Andy Polyakov <[email protected]> Reviewed-by: Rich Salz <[email protected]> (Merged from #6245)
Contributor
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from commit 5c6a69f.
Partial Back-port of #6133 to 1.1.0
Checklist