bn/asm/*-mont.pl: harmonize with BN_from_montgomery_word.#6163
Closed
dot-asm wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Closed
bn/asm/*-mont.pl: harmonize with BN_from_montgomery_word.#6163dot-asm wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
dot-asm wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Conversation
Montgomery multiplication post-conditions in some of code paths were formally non-constant time. Cache access pattern was result-neutral, but a little bit asymmetric, which might have produced a signal [if processor reordered load and stores at run-time]. Reviewed-by: Rich Salz <[email protected]> (Merged from openssl#6141) (cherry picked from commit 774ff8f)
richsalz
approved these changes
May 3, 2018
richsalz
added
the
approval: done
Contributor
Author
|
For the record, red cross from travis is unrelated, busted[?] gcc-5 package. |
levitte
pushed a commit
that referenced
this pull request
May 4, 2018
Montgomery multiplication post-conditions in some of code paths were formally non-constant time. Cache access pattern was result-neutral, but a little bit asymmetric, which might have produced a signal [if processor reordered load and stores at run-time]. Reviewed-by: Rich Salz <[email protected]> (Merged from #6163) (cherry picked from commit 774ff8f) Resolved conflicts in ppc-mont.pl and x86_64-mont.pl.
levitte
pushed a commit
that referenced
this pull request
May 4, 2018
Montgomery multiplication post-conditions in some of code paths were formally non-constant time. Cache access pattern was result-neutral, but a little bit asymmetric, which might have produced a signal [if processor reordered load and stores at run-time]. Reviewed-by: Rich Salz <[email protected]> (Merged from #6163) (cherry picked from commit 774ff8f) Resolved conflicts in ppc-mont.pl and x86_64-mont.pl. (cherry picked from commit d067ba3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Montgomery multiplication post-conditions in some of code paths were
formally non-constant time. Cache access pattern was result-neutral,
but a little bit asymmetric, which might have produced a signal [if
processor reordered load and stores at run-time].
Reviewed-by: Rich Salz [email protected]
(Merged from #6141)
(cherry picked from commit 774ff8f)