v3_purp.c: add locking to x509v3_cache_extensions()#6162
Closed
mspncp wants to merge 1 commit intoopenssl:masterfrom
Closed
v3_purp.c: add locking to x509v3_cache_extensions()#6162mspncp wants to merge 1 commit intoopenssl:masterfrom
mspncp wants to merge 1 commit intoopenssl:masterfrom
Conversation
Contributor
Author
|
Cherry-picks cleanly to 1.1.0 but not to 1.0.2 |
mspncp
added
1.1.0
approval: review pending
mspncp
force-pushed
the
pr-add-locking-to-x509v3-cache-extensions
branch
from
9bcc223 to
39c4d33
Compare
Fixes openssl#6121 Thanks to Mingtao Yang for reporting this bug.
mspncp
force-pushed
the
pr-add-locking-to-x509v3-cache-extensions
branch
from
39c4d33 to
5e47d82
Compare
richsalz
approved these changes
May 3, 2018
| if (x->ex_flags & EXFLAG_SET) | ||
| return; | ||
|
|
||
| CRYPTO_THREAD_write_lock(x->lock); |
Contributor
There was a problem hiding this comment.
Maybe add a comment that we need to double-check now that we have the lock?
richsalz
added
approval: done
levitte
pushed a commit
that referenced
this pull request
May 3, 2018
Fixes #6121 Thanks to Mingtao Yang for reporting this bug. Reviewed-by: Rich Salz <[email protected]> (Merged from #6162)
levitte
pushed a commit
that referenced
this pull request
May 3, 2018
Fixes #6121 Thanks to Mingtao Yang for reporting this bug. Reviewed-by: Rich Salz <[email protected]> (Merged from #6162)
Contributor
Author
Contributor
Author
|
* Maybe add a comment that we need to double-check now that we have the lock?
Oh no! I forgot to add the comment before merging! :-/ Please forgive me!
Matthias
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6121
Thanks to Mingtao Yang for reporting this bug.
This is an alternative to pull request #6161.