Small cleanups about opensslconf.h#6149
Closed
FdaSilvaYY wants to merge 1 commit intoopenssl:masterfrom
Closed
Conversation
No need to buildtest on opensslconf.h
FdaSilvaYY
force-pushed
the
opensslconf-cleanup
branch
from
8cf05f9 to
c656e20
Compare
FdaSilvaYY
changed the title
FdaSilvaYY
changed the title
Contributor
Author
|
Ping @levitte : I just open a .d file to see its content, and found these nits .. at the end.. |
levitte
approved these changes
May 2, 2018
levitte
added
the
approval: review pending
mspncp
approved these changes
May 2, 2018
mspncp
added
approval: done
Member
|
Merged. c7e1075 opensslconf.h inclusion cleanup No need to buildtest on opensslconf.h |
levitte
pushed a commit
that referenced
this pull request
May 2, 2018
No need to buildtest on opensslconf.h Reviewed-by: Matthias St. Pierre <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #6149)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
There two duplicate inclusions,
And no need to
generate_buildtest.plon opensslconf.h as it is the 1st include made in it.