Fix SSL_get_shared_ciphers() (1.1.0)#6114
Closed
mattcaswell wants to merge 5 commits intoopenssl:OpenSSL_1_1_0-stablefrom
Closed
Fix SSL_get_shared_ciphers() (1.1.0)#6114mattcaswell wants to merge 5 commits intoopenssl:OpenSSL_1_1_0-stablefrom
mattcaswell wants to merge 5 commits intoopenssl:OpenSSL_1_1_0-stablefrom
Conversation
The function SSL_get_shared_ciphers() is supposed to return ciphers shared by the client and the server. However it only ever returned the client ciphers. Fixes openssl#5317
The ciphers field in a session contains the stack of ciphers offered by the client.
Contributor
|
I prefer this not get fixed because I prefer master/1.1.1 not get fixed. It is an incompatible change, even though it makes sense. |
2 tasks
levitte
approved these changes
May 2, 2018
levitte
pushed a commit
that referenced
this pull request
May 2, 2018
The function SSL_get_shared_ciphers() is supposed to return ciphers shared by the client and the server. However it only ever returned the client ciphers. Fixes #5317 Reviewed-by: Richard Levitte <[email protected]> (Merged from #6114)
Member
Author
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
May 2, 2018
The ciphers field in a session contains the stack of ciphers offered by the client. Reviewed-by: Richard Levitte <[email protected]> (Merged from #6114)
levitte
pushed a commit
that referenced
this pull request
May 2, 2018
Reviewed-by: Richard Levitte <[email protected]> (Merged from #6114)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function SSL_get_shared_ciphers() is supposed to return ciphers shared
by the client and the server. However it only ever returned the client
ciphers.
Fixes #5317
This is the 1.1.0 version of #6113