Remove some logically dead code#6049
Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Closed
Conversation
This dead code should have been removed as part of openssl#5874 but got missed. Found by Coverity.
richsalz
approved these changes
Apr 23, 2018
Contributor
richsalz
left a comment
richsalz
left a comment
There was a problem hiding this comment.
should be kinda low on the priority list :) was coverity complaining?
Member
Author
|
Yeah it was a coverity issue. |
paulidale
approved these changes
Apr 23, 2018
Member
Author
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Apr 24, 2018
This dead code should have been removed as part of #5874 but got missed. Found by Coverity. Reviewed-by: Rich Salz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #6049)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dead code should have been removed as part of #5874 but got missed.
Found by Coverity.
Checklist