Skip to content

Comments

Fix SSL_pending() for DTLS#6020

Closed
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
mattcaswell:fix-ssl-pending-dtls
Closed

Fix SSL_pending() for DTLS#6020
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
mattcaswell:fix-ssl-pending-dtls

Conversation

@mattcaswell
Copy link
Member

DTLS was not correctly returning the number of pending bytes left in
a call to SSL_pending(). This makes the detection of truncated packets
almost impossible.

Fixes #5478

DTLS was not correctly returning the number of pending bytes left in
a call to SSL_pending(). This makes the detection of truncated packets
almost impossible.

Fixes openssl#5478
@mattcaswell mattcaswell added branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) labels Apr 19, 2018
@richsalz
Copy link
Contributor

But boy, all those fake functions in record_locl.h are ugly. :)

@mattcaswell
Copy link
Member Author

Pushed. Thanks.

levitte pushed a commit that referenced this pull request Apr 20, 2018
DTLS was not correctly returning the number of pending bytes left in
a call to SSL_pending(). This makes the detection of truncated packets
almost impossible.

Fixes #5478

Reviewed-by: Rich Salz <[email protected]>
(Merged from #6020)
levitte pushed a commit that referenced this pull request Apr 20, 2018
Reviewed-by: Rich Salz <[email protected]>
(Merged from #6020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants