Make sure SSL_in_init() returns 0 at SSL_CB_HANDSHAKE_DONE#6019
Closed
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
Closed
Make sure SSL_in_init() returns 0 at SSL_CB_HANDSHAKE_DONE#6019mattcaswell wants to merge 2 commits intoopenssl:masterfrom
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
Conversation
In 1.1.0 and before calling SSL_in_init() from the info_callback at SSL_CB_HANDSHAKE_DONE would return 0. This commit fixes it so that it does again for 1.1.1. This broke Node. Fixes openssl#4574
Check that in a handshake done event SSL_in_init() is 0 (see openssl#4574)
mattcaswell
added
branch: master
richsalz
approved these changes
Apr 19, 2018
richsalz
added
the
approval: done
Member
Author
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Apr 20, 2018
In 1.1.0 and before calling SSL_in_init() from the info_callback at SSL_CB_HANDSHAKE_DONE would return 0. This commit fixes it so that it does again for 1.1.1. This broke Node. Fixes #4574 Reviewed-by: Rich Salz <[email protected]> (Merged from #6019)
levitte
pushed a commit
that referenced
this pull request
Apr 20, 2018
Check that in a handshake done event SSL_in_init() is 0 (see #4574) Reviewed-by: Rich Salz <[email protected]> (Merged from #6019)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.1.0 and before calling SSL_in_init() from the info_callback
at SSL_CB_HANDSHAKE_DONE would return 0. This commit Fixes it so
that it does again for 1.1.1. This broke Node.
Fixes #4574