Update EVP_DigestSignInit() docs#5992
Closed
mattcaswell wants to merge 2 commits intoopenssl:masterfrom
Closed
Conversation
Explicitly state which digests can be used with which algorithms. Fixes openssl#5854
Member
Author
|
It's not clear to me if the restriction that you cannot use SHA3 with ECDSA is intentional or not. Perhaps @dot-asm can comment. |
richsalz
suggested changes
Apr 17, 2018
doc/man3/EVP_DigestSignInit.pod
Outdated
|
|
||
| Only EVP_PKEY types that support signing can be used with these functions. This | ||
| includes MAC algorithms where the MAC generation is considered as a form of | ||
| "signing". Built-in EVP_PKEY types supported by these functions are CMAC, |
Contributor
There was a problem hiding this comment.
Punctuation inside the quotes.
doc/man3/EVP_DigestSignInit.pod
Outdated
| Poly1305, DSA, HMAC, RSA, Siphash, Ed25519 and Ed448. | ||
|
|
||
| Not all digests can be used for all key types. The following combinations apply. | ||
| DSA supports SHA1, SHA224, SHA256, SHA384 and SHA512. ECDSA supports SHA1, |
Contributor
There was a problem hiding this comment.
Would this be more digestible as a table or list? (E.g., using over/item/back constructs). At a minimum, it should be alphabetized.
Contributor
|
Look at https://tools.ietf.org/html/draft-turner-lamps-adding-sha3-to-pkix-01 It's clearly in the works, so if we can support it we should probably do so. |
Member
Author
|
Fixup commit pushed addressing comments. |
Member
|
Any thoughts on backporting this to 1.1.0? |
FdaSilvaYY
reviewed
Apr 17, 2018
| Only EVP_PKEY types that support signing can be used with these functions. This | ||
| includes MAC algorithms where the MAC generation is considered as a form of | ||
| "signing." Built-in EVP_PKEY types supported by these functions are CMAC, | ||
| Poly1305, DSA, HMAC, RSA, Siphash, Ed25519 and Ed448. |
levitte
pushed a commit
that referenced
this pull request
Apr 18, 2018
Explicitly state which digests can be used with which algorithms. Fixes #5854 Reviewed-by: Rich Salz <[email protected]> (Merged from #5992)
Member
Author
|
Pushed (including @FdaSilvaYY typo fix). PR coming up for 1.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly state which digests can be used with which algorithms.
Fixes #5854