Skip to content

Comments

p5_scrypt.c: fix error check of RAND_bytes() call#5977

Closed
mspncp wants to merge 1 commit intoopenssl:masterfrom
mspncp:pr-p5-scrypt-fix-rand-bytes-error-check
Closed

p5_scrypt.c: fix error check of RAND_bytes() call#5977
mspncp wants to merge 1 commit intoopenssl:masterfrom
mspncp:pr-p5-scrypt-fix-rand-bytes-error-check

Conversation

@mspncp
Copy link
Contributor

@mspncp mspncp commented Apr 17, 2018

No description provided.

@mspncp
Copy link
Contributor Author

mspncp commented Apr 17, 2018

Can anyone explain this test failure to me? (see https://travis-ci.org/openssl/openssl/jobs/367508858)

Test Summary Report

-------------------

../../_srcdist/test/recipes/70-test_key_share.t              (Wstat: 15360 Tests: 21 Failed: 0)

  Non-zero exit status: 60

  Parse errors: Bad plan.  You planned 22 tests but ran 21.

Files=146, Tests=1336, 201 wallclock secs ( 5.35 usr  1.48 sys + 76.70 cusr 23.44 csys = 106.97 CPU)

Result: FAIL

make[1]: *** [_tests] Error 1

@levitte
Copy link
Member

levitte commented Apr 17, 2018

Yup

ok 21 - Ignore key_share for TLS<=1.2 server

Server command: ../../util/shlib_wrap.sh ../../apps/openssl s_server -max_protocol TLSv1.3 -no_comp -rev -engine ossltest -accept [::1]:0 -cert ../../../_srcdist/apps/server.pem -cert2 ../../../_srcdist/apps/server.pem -naccept 1 -cipher AES128-SHA -ciphersuites TLS_AES_128_GCM_SHA256 -curves X25519

engine "ossltest" set.

Using default temp DH parameters

ACCEPT [::1]:52821

Server responds on [::1]:52821

unable to connect: Operation timed out

# Looks like you planned 22 tests but ran 21.

# Looks like your test exited with 60 just after 21.

Dubious, test returned 60 (wstat 15360, 0x3c00)

Failed 1/22 subtests

@levitte
Copy link
Member

levitte commented Apr 17, 2018

We do have that issue going on a little now and then. @dot-asm and @bernd-edlinger seem to be working on it

@levitte
Copy link
Member

levitte commented Apr 17, 2018

I restarted that job, let's hope we get a better result this time

@mspncp mspncp self-assigned this Apr 17, 2018
@mspncp mspncp added the approval: done This pull request has the required number of approvals label Apr 17, 2018
@bernd-edlinger bernd-edlinger mentioned this pull request Apr 17, 2018
Closed
@mspncp mspncp added branch: master Applies to master branch 1.1.0 labels Apr 17, 2018
@mspncp
Copy link
Contributor Author

mspncp commented Apr 17, 2018

The patch applies cleanly to 1.1.0. Branch 1.0.2 does not seem to be affected.

levitte pushed a commit that referenced this pull request Apr 17, 2018
@mspncp
p5_scrypt.c: fix error check of RAND_bytes() call
6971250 
Reviewed-by: Kurt Roeckx <[email protected]>
(Merged from #5977)
levitte pushed a commit that referenced this pull request Apr 17, 2018
@mspncp
p5_scrypt.c: fix error check of RAND_bytes() call
e62fb0d 
Reviewed-by: Kurt Roeckx <[email protected]>
(Merged from #5977)
levitte pushed a commit that referenced this pull request Apr 17, 2018
@mspncp
SSL_CTX_set_tlsext_ticket_key_cb.pod: fix error check of RAND_bytes()…
a12de2c 
… call

Reviewed-by: Rich Salz <[email protected]>
(Merged from #5977)
@mspncp
Copy link
Contributor Author

mspncp commented Apr 17, 2018

Merged!

e62fb0d master
6971250 1.1.0

@mspncp mspncp closed this Apr 17, 2018
@mspncp mspncp deleted the pr-p5-scrypt-fix-rand-bytes-error-check branch April 17, 2018 15:34
@mspncp mspncp mentioned this pull request Apr 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroeckx kroeckx kroeckx approved these changes

Assignees

@mspncp mspncp

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mspncp @levitte @kroeckx