recipes/70-test_ssl{cbcpadding,extension,records}: make it work w/fragmentation.#5975
Closed
dot-asm wants to merge 7 commits intoopenssl:masterfrom
Closed
recipes/70-test_ssl{cbcpadding,extension,records}: make it work w/fragmentation.#5975dot-asm wants to merge 7 commits intoopenssl:masterfrom
dot-asm wants to merge 7 commits intoopenssl:masterfrom
Conversation
added 4 commits
April 16, 2018 22:54
(and resolve uninitialized variable warning).
…gmentation. This fixes only those tests that were failing when network data was fragmented. Remaining ones might succeed for "wrong reasons". Bunch of tests have to fail to be considered successful and when data is fragmented they might fail for reasons other than originally intended.
levitte
requested changes
Apr 17, 2018
test/recipes/70-test_sslcbcpadding.t
Outdated
| } | ||
|
|
||
| { | ||
| my $sent_corrupted_payload; |
test/recipes/70-test_sslextension.t
Outdated
| } | ||
|
|
||
| { | ||
| my $sent_unsolisited_extension; |
test/recipes/70-test_sslrecords.t
Outdated
| } | ||
|
|
||
| { | ||
| my $added_record; |
Member
|
Have you actually ever observed such short fragments? |
Contributor
Author
Of course not. It's just [artificial] 1-byte fragmentation is meaningful thing to test. Because it works as insurance that there are no unexpected surprises when fragmentation happen to coincide with record boundaries. On related note, to question of 0e3ecae vs. c53c2fe. 1-byte fragmentation makes data flow equivalent to the latter, i.e. forwarding complete records as they become available... |
levitte
approved these changes
Apr 18, 2018
levitte
pushed a commit
that referenced
this pull request
Apr 18, 2018
Reviewed-by: Richard Levitte <[email protected]> (Merged from #5975)
levitte
pushed a commit
that referenced
this pull request
Apr 18, 2018
Reviewed-by: Richard Levitte <[email protected]> (Merged from #5975)
levitte
pushed a commit
that referenced
this pull request
Apr 18, 2018
(resolve uninitialized variable warning and harmonize output). Reviewed-by: Richard Levitte <[email protected]> (Merged from #5975)
levitte
pushed a commit
that referenced
this pull request
Apr 18, 2018
…gmentation. This fixes only those tests that were failing when network data was fragmented. Remaining ones might succeed for "wrong reasons". Bunch of tests have to fail to be considered successful and when data is fragmented they might fail for reasons other than originally intended. Reviewed-by: Richard Levitte <[email protected]> (Merged from #5975)
levitte
pushed a commit
that referenced
this pull request
Apr 18, 2018
s_server -rev emits info output on stderr, i.e. unbufferred, which risks intermixing with output from TLSProxy itself on non-line boundaries, which in turn is confusing to TAP parser. Reviewed-by: Richard Levitte <[email protected]> (Merged from #5975)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes only those tests that were failing when network data was
fragmented. Remaining ones might succeed for "wrong reasons". Bunch
of tests have to fail to be considered successful and when data is
fragmented they might fail for reasons other than originally intended.
make test TESTS=70 works even with 1-byte fragmentation...
Checklist