BIGNUM signed add/sub routines refactory#5963
Closed
davxy wants to merge 1 commit intoopenssl:masterfrom
davxy:bn_add_refact
Closed
BIGNUM signed add/sub routines refactory#5963davxy wants to merge 1 commit intoopenssl:masterfrom davxy:bn_add_refact
davxy wants to merge 1 commit intoopenssl:masterfrom
davxy:bn_add_refact
Conversation
openssl-machine
added
the
hold: cla required
Contributor
|
Close/open to kick the CLA bot. |
openssl-machine
removed
the
hold: cla required
Contributor
davidben
reviewed
Apr 16, 2018
crypto/bn/bn_add.c
Outdated
Contributor
There was a problem hiding this comment.
Why not just r_neg = !b->neg?
Contributor
Author
There was a problem hiding this comment.
Looks a lot better. Fixed
Old code replaced in favor of a clearer implementation. Performances are not penalized. Updated the copyright end date to 2018.
Contributor
Author
davidben
approved these changes
Apr 17, 2018
levitte
pushed a commit
that referenced
this pull request
Apr 17, 2018
Old code replaced in favor of a clearer implementation. Performances are not penalized. Updated the copyright end date to 2018. Reviewed-by: David Benjamin <[email protected]> Reviewed-by: Rich Salz <[email protected]> (Merged from #5963)
Contributor
|
Merged to master, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old code replaced in favor of a clearer implementation.
Performances are not penalized.
Updated the copyright end date to 2018.
The new implementation succeeded with the provided BIGNUM unit tests and is functionally equivalent
to the previous one, only a bit cleaner.
Checklist