apps/s_socket.c: print only dynamically allocated port in do_server.#5956
Closed
dot-asm wants to merge 1 commit intoopenssl:masterfrom
Closed
apps/s_socket.c: print only dynamically allocated port in do_server.#5956dot-asm wants to merge 1 commit intoopenssl:masterfrom
dot-asm wants to merge 1 commit intoopenssl:masterfrom
Conversation
For formal backward compatibility print original "ACCEPT" message for fixed port and "ACCEPT host:port" for dynamically allocated.
levitte
reviewed
Apr 14, 2018
| } else { | ||
| (void)BIO_printf(bio_s_out, "ACCEPT\n"); | ||
| (void)BIO_flush(bio_s_out); | ||
| } |
Member
There was a problem hiding this comment.
Side note: Since both branches of the condition do BIO_flush, an option would be to bring it down below...
bernd-edlinger
approved these changes
Apr 15, 2018
levitte
approved these changes
Apr 16, 2018
levitte
pushed a commit
that referenced
this pull request
Apr 17, 2018
For formal backward compatibility print original "ACCEPT" message for fixed port and "ACCEPT host:port" for dynamically allocated. Reviewed-by: Bernd Edlinger <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #5956)
| res = NULL; | ||
|
|
||
| { | ||
| if (BIO_ADDR_rawport(sock_address) == 0) { |
Member
There was a problem hiding this comment.
I think BIO_ADDRINFO_free(res) above makes sock_address invalid
Proxy started on port 127.0.0.1:39053
Server command: ../../util/shlib_wrap.sh ../../apps/openssl s_server -max_protocol TLSv1.3 -no_comp -rev -engine ossltest -accept 127.0.0.1:0 -cert ../../apps/server.pem -cert2 ../../apps/server.pem -naccept 1 -cipher AES128-SHA -ciphersuites TLS_AES_128_GCM_SHA256
engine "ossltest" set.
Using default temp DH parameters
==30331==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7f33fc8a46b5 in BIO_ADDR_rawport /home/travis/build/openssl/openssl/crypto/bio/b_addr.c:167:9
#1 0x59f12c in do_server /home/travis/build/openssl/openssl/apps/s_socket.c:286:9
#2 0x539ec2 in s_server_main /home/travis/build/openssl/openssl/apps/s_server.c:2109:5
#3 0x4f8b78 in do_cmd /home/travis/build/openssl/openssl/apps/openssl.c:564:16
#4 0x4f88b3 in main /home/travis/build/openssl/openssl/apps/openssl.c:183:15
#5 0x7f33fb8e5f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
#6 0x43502e in _start (/home/travis/build/openssl/openssl/apps/openssl+0x43502e)
SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/travis/build/openssl/openssl/crypto/bio/b_addr.c:167:9 in BIO_ADDR_rawport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For formal backward compatibility print original "ACCEPT" message for
fixed port and "ACCEPT host:port" for dynamically allocated.