Ignore the status_request extension in a resumption handshake (1.0.2)#5898
Closed
mattcaswell wants to merge 1 commit intoopenssl:OpenSSL_1_0_2-stablefrom
Closed
Ignore the status_request extension in a resumption handshake (1.0.2)#5898mattcaswell wants to merge 1 commit intoopenssl:OpenSSL_1_0_2-stablefrom
mattcaswell wants to merge 1 commit intoopenssl:OpenSSL_1_0_2-stablefrom
Conversation
We cannot provide a certificate status on a resumption so we should ignore this extension in that case. Fixes openssl#1662
This was referenced Apr 6, 2018
richsalz
approved these changes
Apr 6, 2018
kaduk
reviewed
Apr 6, 2018
| goto err; | ||
| } else if (type == TLSEXT_TYPE_status_request) { | ||
|
|
||
| } else if (type == TLSEXT_TYPE_status_request && !s->hit) { |
Contributor
There was a problem hiding this comment.
do we need to increment data by size if we're skipping processing?
Member
Author
There was a problem hiding this comment.
No, it does that at the end of the loop
Contributor
There was a problem hiding this comment.
That will teach me, only looking at the top of the loop...
levitte
pushed a commit
that referenced
this pull request
Apr 17, 2018
We cannot provide a certificate status on a resumption so we should ignore this extension in that case. Fixes #1662 Reviewed-by: Rich Salz <[email protected]> (Merged from #5898)
Member
Author
|
Pushed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot provide a certificate status on a resumption so we should
ignore this extension in that case.
Fixes #1662
This is the 1.0.2 version of #5896