Conversation
|
The travis and appveyor failures do not appear relevant (ping @levitte - seems to be something to do with the new versions.c file) |
|
????? Uhmmmmm... the appveyor failure looks weird... why does the compilation of As for the Travis one, impossible to analyse because of the ... wisdom of making make silent. Would you mind hacking the default jobs to set |
|
BTW, you might want to not include |
|
Ahhhh, it's actually the That was unforeseen, I'll have a look at Configure to make it more robust against this kind of, err, "attack" |
|
But, suffice to say, removing |
mattcaswell
force-pushed
the
info-callback
branch
from
daf9eff to
b3c6dc3
Compare
|
Gah!! Thanks. Update force pushed. I'm off to update .gitignore... |
richsalz
added
the
approval: done
The first session ticket sent by the server is actually tacked onto the end of the first handshake from a state machine perspective. However in reality this is a post-handshake message, and should be preceeded by a handshake start event from an info callback perspective.
Make sure the info callback gets called in all the places we expect it to.
mattcaswell
force-pushed
the
info-callback
branch
from
b3c6dc3 to
00df0f8
Compare
|
There was a merge conflict with master. Rebased. @richsalz - can you reconfirm? |
|
Reconfirm. |
|
Pushed. Thanks. |
Fixes #5721 Reviewed-by: Rich Salz <[email protected]> (Merged from #5874)
The first session ticket sent by the server is actually tacked onto the end of the first handshake from a state machine perspective. However in reality this is a post-handshake message, and should be preceeded by a handshake start event from an info callback perspective. Reviewed-by: Rich Salz <[email protected]> (Merged from #5874)
Make sure the info callback gets called in all the places we expect it to. Reviewed-by: Rich Salz <[email protected]> (Merged from #5874)
Reviewed-by: Rich Salz <[email protected]> (Merged from #5874)
This dead code should have been removed as part of openssl#5874 but got missed. Found by Coverity.
This dead code should have been removed as part of #5874 but got missed. Found by Coverity. Reviewed-by: Rich Salz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #6049)
3 participants
The info callback was not receiving all the handshake start and done events that it should in TLSv1.3. This fixes it and adds a test. I also updated the documentation to explain the meaning of the various events in a TLSv1.3 context.
Fixes #5721.
Checklist