Don't distribute team internal config targets#5836
Don't distribute team internal config targets#5836levitte wants to merge 2 commits intoopenssl:masterfrom
Conversation
levitte
added
branch: master
richsalz
left a comment
richsalz
left a comment
There was a problem hiding this comment.
Okay, but why not release it?
|
The name alone should be enough of a hint. It's a bunch of random team configs which are hardly relevant for public distribution. If you want to use them, t them with git. |
|
Shrug. Seems like demo's, kinda worthwhile to have as examples, but NBD. |
|
This PR is ready, no ? |
|
Not quite, the "dist" target needs to be moved, or it must be used differently... |
richsalz
added
the
approval: done
Configurations/90-team.conf isn't for public consumption, so we rename it to 90-team.norelease.conf and make sure 'make dist' and 'make tar' don't include it in the tarball.
levitte
force-pushed
the
do-not-distribute-team-internal-configs
branch
from
b86c396 to
3ec02da
Compare
|
(closed and re-opened to see that the CIs agree) I made the small change of moving the "dist" config target to its own file. This should be good to go now, but needs re-approval. |
|
Reconfimr. |
Configurations/90-team.conf isn't for public consumption, so we rename it to 90-team.norelease.conf and make sure 'make dist' and 'make tar' don't include it in the tarball. Reviewed-by: Rich Salz <[email protected]> (Merged from #5836)
|
Merged. master / 1.1.1: It turns out that this doesn't cherry-pick cleanly to 1.1.0. I'll make another PR for it. |
3 participants
Configurations/90-team.conf isn't for public consumption, so we rename
it to 90-team.norelease.conf and make sure 'make dist' and 'make tar'
don't include it in the tarball.