Skip to content

Ensure we init libssl after any engines have been loaded#5813

Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell:fix-gost-engine-load
Closed

Ensure we init libssl after any engines have been loaded#5813
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell:fix-gost-engine-load

Conversation

@mattcaswell
Copy link
Member

The GOST engine needs to be loaded before we initialise libssl. Otherwise
the GOST ciphersuites are not enabled. However the SSL conf module must
be loaded before we initialise libcrypto. Otherwise we will fail to read
the SSL config from a config file properly.

Fixes #5809

The GOST engine needs to be loaded before we initialise libssl. Otherwise
the GOST ciphersuites are not enabled. However the SSL conf module must
be loaded before we initialise libcrypto. Otherwise we will fail to read
the SSL config from a config file properly.
@mattcaswell mattcaswell added branch: master Applies to master branch 1.1.0 branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) labels Mar 30, 2018
@mattcaswell mattcaswell added this to the 1.1.1 milestone Mar 30, 2018
@mattcaswell mattcaswell requested a review from levitte March 30, 2018 15:44
@mattcaswell
Copy link
Member Author

This isn't a perfect solution. There is still an issue where an application uses libcrypto before it uses libssl. But its better than what we had before.

Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to me

@mattcaswell
Copy link
Member Author

Closed in favour of #5879 and #5818.

@mattcaswell mattcaswell closed this Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants