correct spelling errors detected by Debian lintian#5801
correct spelling errors detected by Debian lintian#5801andreasschulze wants to merge 1 commit intoopenssl:masterfrom andreasschulze:spelling-errors
Conversation
openssl-machine
added
the
hold: cla required
richsalz
left a comment
richsalz
left a comment
There was a problem hiding this comment.
Can you sign our CLA or put
CLA: trivial
in the body of your commit message? Thank you! I agree this is trivial.
openssl-machine
added
the
hold: cla required
|
Reopening, to give the cla bot another try. |
openssl-machine
added
the
hold: cla required
|
unsure about the best way to put "CLA: trivial" in a commit message. Is this enougth or should I create a new pull request? |
|
I see that the email is not what we have in our CLA list (see the cla-check above). Send a new CLA or set the Author to be your regular email. |
openssl-machine
added
the
hold: cla required
|
The reason that the CLA checker can't process this correctly is that the commit message looks like this: There's no empty line between the two, which means that they get merged into a subject line in git terms. If you look at the resulting patch, you can see clearly what happens. This is an impossible thing to check correctly... So I think that we can approve this, and if need be, edit the commit message to insert that empty line when merging. I can take it upon myself, if everyone that approves agrees this is legally trivial. |
levitte
left a comment
levitte
left a comment
There was a problem hiding this comment.
Formally: this is legally trivial
levitte
removed
the
hold: cla required
|
I agree it's trivial. |
|
Merged into master. aa3b328 correct spelling errors detected by Debian lintian |
CLA: trivial Reviewed-by: Matthias St. Pierre <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #5801)
|
This should really be cherry-picked to 1.1.0 and possibly 1.0.2. Does anyone approve? |
|
+1. Go ahead, if it applies. |
|
Actually, it seems the changes here only apply to master, so closing this |
5 participants
trivial contribution
CLA: trivial
Checklist