Move the handling of dso_scheme to dso_conf.h#5733
Closed
levitte wants to merge 4 commits intoopenssl:masterfrom
Closed
Move the handling of dso_scheme to dso_conf.h#5733levitte wants to merge 4 commits intoopenssl:masterfrom
levitte wants to merge 4 commits intoopenssl:masterfrom
Conversation
The macros resulting from the dso_scheme attribute were defined for libraries only, but there's a test program that uses the macros as well. The easier way is to move the handling of this macro to crypto/include/internal/dso_conf.h and having the modules that need it include it.
levitte
added
branch: master
These errors were hidden because compiling this file didn't get the macros derived from the dso_scheme attribute, and therefore, some code never got compiled.
levitte
changed the title
levitte
referenced
this pull request
Mar 23, 2018
When doing a regression test, it's obvious that the version test/shlibloadtest is built for will not be the same as the library version. So we change the test to check for assumed compatibility. Reviewed-by: Andy Polyakov <[email protected]> (Merged from #5619)
Contributor
|
appveryor failure is relevant. |
myDSO_dsobyaddr and myDSO_free are only used in a narrow block of code, and can therefore be made local to that block. Otherwise, some compilers may warn that they are unused.
Member
Author
|
I see why. New commit should clear that issue. |
dot-asm
approved these changes
Mar 23, 2018
dot-asm
added
the
approval: done
levitte
added a commit
that referenced
this pull request
Mar 23, 2018
The macros resulting from the dso_scheme attribute were defined for libraries only, but there's a test program that uses the macros as well. The easier way is to move the handling of this macro to crypto/include/internal/dso_conf.h and having the modules that need it include it. Reviewed-by: Andy Polyakov <[email protected]> (Merged from #5733)
levitte
added a commit
that referenced
this pull request
Mar 23, 2018
Reviewed-by: Andy Polyakov <[email protected]> (Merged from #5733)
levitte
added a commit
that referenced
this pull request
Mar 23, 2018
These errors were hidden because compiling this file didn't get the macros derived from the dso_scheme attribute, and therefore, some code never got compiled. Reviewed-by: Andy Polyakov <[email protected]> (Merged from #5733)
levitte
added a commit
that referenced
this pull request
Mar 23, 2018
myDSO_dsobyaddr and myDSO_free are only used in a narrow block of code, and can therefore be made local to that block. Otherwise, some compilers may warn that they are unused. Reviewed-by: Andy Polyakov <[email protected]> (Merged from #5733)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macros resulting from the dso_scheme attribute were defined for
libraries only, but there's a test program that uses the macros as
well. The easier way is to move the handling of this macro to
crypto/include/internal/dso_conf.h and having the modules that need it
include it.