Adds multiple checks to avoid buffer over reads [1.1.0]#5686
Closed
catenacyber wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Closed
Adds multiple checks to avoid buffer over reads [1.1.0]#5686catenacyber wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
catenacyber wants to merge 1 commit intoopenssl:OpenSSL_1_1_0-stablefrom
Conversation
openssl-machine
added
the
hold: cla required
openssl-machine
removed
the
hold: cla required
levitte
changed the title
richsalz
approved these changes
Mar 20, 2018
richsalz
added
1.1.0
approval: review pending
ssl/t1_trce.c
Outdated
Member
There was a problem hiding this comment.
this change is not really fixing an overrun because of the condition above.
note there is a similar loop in line 1085 while (xlen > 0) {
Member
There was a problem hiding this comment.
I would'nt mind changing the other loop as well to avoid unnecessary head scratching...
bernd-edlinger
requested changes
Mar 24, 2018
Member
bernd-edlinger
left a comment
bernd-edlinger
left a comment
There was a problem hiding this comment.
please update this PR to match #5675
bernd-edlinger
approved these changes
Mar 26, 2018
richsalz
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Mar 27, 2018
Reviewed-by: Rich Salz <[email protected]> Reviewed-by: Bernd Edlinger <[email protected]> (Merged from #5686)
Member
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5675