Add a simple method to run regression tests#5619
Add a simple method to run regression tests#5619levitte wants to merge 5 commits intoopenssl:masterfrom
Conversation
|
This isn't terribly interesting for master until there's a letter update for 1.1.1 or when/if 1.1.2 comes along. However, I'm also backporting to 1.1.0, and that could prove interesting... |
Probably it will fail miserably due to lots of in-built assumptions in the tests about TLSv1.2 being the maximum available protocol. |
|
Yup, I know, and perhaps we should modify the tests accordingly. However, I've found other regression failures that do worry me, among others in |
|
What is the output of the cd command? This syntax confuses me. |
|
Ah, I forgot |
levitte
force-pushed
the
regression-test
branch
from
c97a3c7 to
cc875a2
Compare
util/shlib_wrap.sh.in
Outdated
There was a problem hiding this comment.
Wouldn't it be more appropriate to check for -x? Secondly one can wonder if it would be appropriate to handle the error instead of ignoring. I mean if you set OPENSSL_REGRESSION and there is nothing there, you might appreciate an error message that there is nothing there, rather than silent execution with shared libraries in current build tree. Otherwise you give an impression that it regression test succeeded.
This is only useful when building shared libraries. This allows us to
run our tests against newer libraries when the time comes. Simply do
this:
OPENSSL_REGRESSION=/other/OpenSSL/build/tree make test
($OPENSSL_REGRESSION *must* be an absolute path)
When doing a regression test, it's obvious that the version test/shlibloadtest is built for will not be the same as the library version. So we change the test to check for assumed compatibility.
levitte
force-pushed
the
regression-test
branch
from
99f1d0b to
12e798f
Compare
util/shlib_wrap.sh.in
Outdated
| # we exec also support that mechanism... | ||
| OPENSSL_REGRESSION= exec "$shlibwrap" "$@" | ||
| else | ||
| if [ -f "$OPENSSL_REGRESSION" ]; then |
There was a problem hiding this comment.
I suppose you meant to check -f "$shlibwrap", not $OPENSSL_REGRESSION. I also sense inconsistency in quoting. For example -n "$OPENSSL_REGRESSION" suggests that you are willing to tolerate white spaces in $OPENSSL_REGRESSION. But next line, shlibwrap won't tolerate them.
This is only useful when building shared libraries. This allows us to
run our tests against newer libraries when the time comes. Simply do
this:
OPENSSL_REGRESSION=/other/OpenSSL/build/tree make test
($OPENSSL_REGRESSION *must* be an absolute path)
Reviewed-by: Andy Polyakov <[email protected]>
(Merged from #5619)
When doing a regression test, it's obvious that the version test/shlibloadtest is built for will not be the same as the library version. So we change the test to check for assumed compatibility. Reviewed-by: Andy Polyakov <[email protected]> (Merged from #5619)
4 participants
This is only useful when building shared libraries. This allows us to
run our tests against newer libraries when the time comes. Simply do
this:
(
$OPENSSL_REGRESSIONmust be an absolute path)