Document EC_POINT_get_affine_coordinates_*.#5532
Closed
davidben wants to merge 1 commit intoopenssl:masterfrom
Closed
Document EC_POINT_get_affine_coordinates_*.#5532davidben wants to merge 1 commit intoopenssl:masterfrom
davidben wants to merge 1 commit intoopenssl:masterfrom
Conversation
In particular, x and y may be NULL, as used in ecdsa_ossl.c. Make use of this in ecdh_ossl.c as well, to save an otherwise unnecessary temporary.
paulidale
approved these changes
Mar 20, 2018
mattcaswell
approved these changes
Mar 21, 2018
mattcaswell
added
approval: done
Member
|
My approval counts for 1.1.0 too if you want to backport it there. |
Contributor
Author
|
Merged as ddc1caa. Hopefully I got it right this time. :-) |
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2018
In particular, x and y may be NULL, as used in ecdsa_ossl.c. Make use of this in ecdh_ossl.c as well, to save an otherwise unnecessary temporary. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #5532)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, x and y may be NULL, as used in ecdsa_ossl.c. Make use of
this in ecdh_ossl.c as well, to save an otherwise unnecessary temporary.
Checklist