Closed
Conversation
We can't add NULL data into a hash
[extended tests]
richsalz
approved these changes
Feb 20, 2018
Member
Author
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Feb 21, 2018
We can't add NULL data into a hash Reviewed-by: Rich Salz <[email protected]> (Merged from #5418)
levitte
pushed a commit
that referenced
this pull request
Feb 21, 2018
[extended tests] Reviewed-by: Rich Salz <[email protected]> (Merged from #5418)
mspncp
added a commit
to mspncp/openssl
that referenced
this pull request
Aug 2, 2018
Fixes openssl#6800 Replaces openssl#5418 This commit reverts commit 7876dbf and moves the check for a zero-length input down the callstack into sha3_update().
levitte
pushed a commit
that referenced
this pull request
Aug 3, 2018
Fixes #6800 Replaces #5418 This commit reverts commit 7876dbf and moves the check for a zero-length input down the callstack into sha3_update(). Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Andy Polyakov <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #6838)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubsan found some issues in the Curve448 code. It also broke no-ec. This fixes both issues.