Skip to content

Comments

Alternate fix for ../test/recipes/80-test_ssl_old.t with no-ec#4981

Closed
bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
bernd-edlinger:fix_no_ec_test_alternate
Closed

Alternate fix for ../test/recipes/80-test_ssl_old.t with no-ec#4981
bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
bernd-edlinger:fix_no_ec_test_alternate

Conversation

@bernd-edlinger
Copy link
Member

Alternative, more aggressive approach at fixing test/recipes/80-test_ssl_old.t;
Seems to work at least with no-ec and no-dh configurations.

and a few remaining empty lines between removed #endif/#ifndef
[to be squashed]
@bernd-edlinger
Copy link
Member Author

tested with no-psk and no-srp as well.

Copy link
Contributor

@richsalz richsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernd-edlinger
Copy link
Member Author

I don't understand what happened with the travis build.

Test Summary Report
-------------------
../../_srcdist/test/recipes/70-test_sslrecords.t             (Wstat: 13 Tests: 3 Failed: 0)
  Non-zero wait status: 13
  Parse errors: Bad plan.  You planned 18 tests but ran 3.
Files=139, Tests=1213, 59 wallclock secs ( 3.14 usr  0.68 sys + 32.73 cusr  2.15 csys = 38.70 CPU)
Result: FAIL

@bernd-edlinger
Copy link
Member Author

assuming that is unrelated ...

levitte pushed a commit that referenced this pull request Dec 27, 2017
@bernd-edlinger
Copy link
Member Author

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants