Various fixes regarding PKCS#12 input and related cleanup of apps, doc, and tests#4930
Various fixes regarding PKCS#12 input and related cleanup of apps, doc, and tests#4930DDvO wants to merge 11 commits intoopenssl:masterfrom
Conversation
|
|
|
I also noticed that doc/man1/s_server.pod is somewhat out of sync. |
|
I think if you have a PKCS#12 file, then you have the certificate, private key and any chain |
|
I agree that typically a PKCS#12 file contains these related types of key material and that it would be logical and most convenient to refer to such a file only once (including any password input). I fear that rectifying this would take some non-negligible effort, including a (backward compatible) extension of the CLI options design for all apps that should support joint PKCS#12 input. Shall we go for that, and who would be willing and have time to help doing this? Nevertheless, the generaliizations I've proprosed here are already useful in themselves - with just the inconvenience that, as before, a PKCS#12 file used not only for key input but also for certificate input needs to be named (together with any password input) more than once. |
586885b to
925d966
Compare
…o_pkcs12() see also openssl#4930 improved OpenSSL 1.0.2 compatibility of cmp.c
levitte
left a comment
There was a problem hiding this comment.
I had these lying around... can't even remember when I wrote them.
925d966 to
0711e0b
Compare
Thanks for these comments. I've just handled them. |
bb43921 to
b0f9f20
Compare
|
The two CI failures currently reported here are unrelated. Ready for further reviewing. |
183a86c to
707b0df
Compare
|
Ping @levitte |
|
Thanks @FdaSilvaYY for having a look. |
Reviewed-by: Tomas Mraz <[email protected]> (Merged from #4930)
Reviewed-by: Tomas Mraz <[email protected]> (Merged from #4930)
Also do a minor extension on the documentation of the -passcerts option Reviewed-by: Tomas Mraz <[email protected]> (Merged from #4930)
|
Merged 😅 I'm glad that this nearly three years old PR, after various adaptations and many long waiting times in between, finally has been brought to a good end, even in time for inclusion in 3.0. Thanks again to @levitte and to all other reviewers for their comments and to @t8m for providing the final push. |
Refs: #4930 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #14520)
UPDATE: Originally this PR was about extending support for PKCS#12 input in apps.
I've meanwhile carved out the most interesting pieces of that and contributed them separately.
This is the leftovers fixing several corner cases in PKCS#12 input and its error handling.
There are also some rather unrelated fixes to several apps and their documentation, which I could separate if requested.
Checklist