WIP: Lhash optional statistics collection.#4427
Closed
paulidale wants to merge 3 commits intoopenssl:masterfrom
Closed
WIP: Lhash optional statistics collection.#4427paulidale wants to merge 3 commits intoopenssl:masterfrom
paulidale wants to merge 3 commits intoopenssl:masterfrom
Conversation
Remove atomic operations from the lhash statistics gathering, an inconsistent output was more than possible. Instead, use a lock. The critical sections are deliberately as small as possible. The rationale for the NULL checks is to allow a future change to where the statistics are optional.
…lock is only ever grabbed once for any operation.
Contributor
Author
|
This is WIP until #4418 is resolved. |
dot-asm
changed the title
Contributor
You can edit subject to denote it as such :-) And apparently I can do it for you. I mean I wanted to test and it worked and I decided to leave it like that... |
Contributor
Author
|
Thanks. |
Closed
1 task
Contributor
Author
|
This PR is unnecessary in light of #4429 |
paulidale
added a commit
to paulidale/openssl
that referenced
this pull request
Oct 4, 2017
indicate the level of locking required for various operations. Remove the lock and atomics from the lhash code. These we're not complete or adequate. Refer to openssl#4418 and openssl#4427 for details.
levitte
pushed a commit
that referenced
this pull request
Oct 8, 2017
indicate the level of locking required for various operations. Remove the lock and atomics from the lhash code. These we're not complete or adequate. Refer to #4418 and #4427 for details. Reviewed-by: Rich Salz <[email protected]> Reviewed-by: Ben Kaduk <[email protected]> Reviewed-by: Andy Polyakov <[email protected]> (Merged from #4429)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the statistics collection in the lhash object optional and disabled by default.
This means zero locking overhead unless the gathering is enabled.
This depends on #4418 for the locking changes to the lhash object. Only the final commit is relevant and this will be squashed before merge.
This is an API breaking change in the sense that the statistics functions
OPENSSL_LH_statsandOPENSSL_LH_stats_biowill not function properly without adding an enable call. The other stats calls still work.