Closed
Conversation
richsalz
approved these changes
Sep 14, 2017
Contributor
richsalz
left a comment
richsalz
left a comment
There was a problem hiding this comment.
ya know, I'd rather we always had the variable and it was always set to null. probably fewer ifdefs then. but that's a larger issue than this.
Contributor
|
@benlaurie It would be useful to know exactly which no-XXX options are of interest to you so that we can add them to our internal CI builds. |
levitte
pushed a commit
that referenced
this pull request
Sep 14, 2017
Reviewed-by: Rich Salz <[email protected]> (Merged from #4369)
Contributor
Author
|
merged; closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should address #4365 (at the cost of an ugly preprocessor conditional that affects control flow)