Add some performance notes about early data#3955
Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Closed
Add some performance notes about early data#3955mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Conversation
In particular add information about the effect of Nagle's algorithm on early data. Fixes openssl#3906
kaduk
approved these changes
Jul 18, 2017
| the ACK is received from the peer. The initial ClientHello will be sent as the | ||
| first TCP packet, causing the early application data from calls to | ||
| SSL_write_early_data() to be buffered by the OS and not sent until an ACK is | ||
| received for the ClientHello packet. This means the early data is not actually |
Contributor
There was a problem hiding this comment.
Well, or if enough early data is queued up to be written. But maybe the previous sentence is enough to cover this possibility.
Member
Author
There was a problem hiding this comment.
Personally I think the previous sentence makes it clear. But if you prefer I could add "(unless enough data is written to fill an entire TCP packet)".
Contributor
There was a problem hiding this comment.
As indicated by the approval review, I defer to your judgment.
Member
Author
|
Pushed, without any amendments. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Jul 18, 2017
In particular add information about the effect of Nagle's algorithm on early data. Fixes #3906 Reviewed-by: Ben Kaduk <[email protected]> (Merged from #3955)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular add information about the effect of Nagle's algorithm on
early data.
Fixes #3906
Checklist