Clarify Oracle's license #3663
Clarify Oracle's license #3663
Conversation
|
I'll pass on the changed version to legal and see what they think. |
kroeckx
force-pushed
the
oracle_copyright
branch
from
2773ab7 to
eda6c09
Compare
|
So my understanding is that we have the needed legal papers from Oracle to put it either under the existing OpenSSL license or the apache2 license. If legal has a problem with putting it like that, we could also just repeat the license text. In either case, I think the current situation seems to indicate that there is no license, while we clearly do have one. |
|
Yes. |
|
I've heard back from legal, the location isn't an issue. The only thing raised was the formatting of the copyright note itself. The approved format is:
Where the first year is the first release and the second is the year of the most recent revision. In this case it differs from what I added by including a single additional comma. The
I.e. adding a comma after the With this proviso, I approve. |
|
I've taken the liberty of making the comma change in #3684. I've also addressed this in all files. |
|
I forget to mention, this PR can be closed since the changes are in the other PR. |
|
Closing as this is covered in #3684 now |
This imports the following changes from OpenSSL: * openssl/openssl@aa8f3d7 * openssl/openssl@5aba2b6 * openssl/openssl@c80149d See the following links for some related discussion in OpenSSL's repository: * openssl/openssl#3663 * openssl/openssl#3684 * openssl/openssl#3585 (comment) * openssl/openssl#3685 The copyright_summary script may be used to compare this CL. Note there is one change to ecdsa_test.cc to align with OpenSSL. See go/openssl-copyright-consolidation-comparison (internal-only). Bug: 364634028 Change-Id: I987c4e145d2ccd0c32bbf9e7bb2cc69e89019d35 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74712 Reviewed-by: Adam Langley <[email protected]> Commit-Queue: David Benjamin <[email protected]>
This imports the following changes from OpenSSL: * openssl/openssl@aa8f3d7 * openssl/openssl@5aba2b6 * openssl/openssl@c80149d See the following links for some related discussion in OpenSSL's repository: * openssl/openssl#3663 * openssl/openssl#3684 * openssl/openssl#3585 (comment) * openssl/openssl#3685 The copyright_summary script may be used to compare this CL. Note there is one change to ecdsa_test.cc to align with OpenSSL. See go/openssl-copyright-consolidation-comparison (internal-only). Bug: 364634028 Change-Id: I987c4e145d2ccd0c32bbf9e7bb2cc69e89019d35 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74712 Reviewed-by: Adam Langley <[email protected]> Commit-Queue: David Benjamin <[email protected]>
@paulidale: Do you agree that this clarifies the situation and that we can merge this?