Skip to content

Comments

util/ and .ctags.d/: remove remaining references to deleted util/check-format.pl#29655

Closed
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:cleanup_check-format.pl
Closed

util/ and .ctags.d/: remove remaining references to deleted util/check-format.pl#29655
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:cleanup_check-format.pl

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Jan 16, 2026

This is a follow-up on #29594, where I wrote the following but my comment got neglected there:

Yeah, #29282 was not really complete w.r.t. removal of check-format.pl.

Since util/check-format.pl was removed, so should also be its internal tests util/check-format-test-{positives,negatives}.c and a reference to check-format-test-positives.c in .ctags.d/exclude.ctags

@DDvO DDvO added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly tests: exempted The PR is exempt from requirements for testing labels Jan 16, 2026
@DDvO DDvO changed the title util/ and .ctags.d/: remove remaining references to deleted util/check-format.pl util/ and .ctags.d/: remove remaining references to deleted util/check-format.pl Jan 16, 2026
@t8m t8m added triaged: bug The issue/pr is/fixes a bug branch: 3.0 Applies to openssl-3.0 branch branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 and removed triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly labels Jan 16, 2026
@t8m
Copy link
Member

t8m commented Jan 16, 2026 •
edited
Loading

IMO this should be backported to all active branches as those leftovers are just confusing and should have been removed with the other PR already.

@esyr esyr added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 16, 2026
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 17, 2026
@openssl-machine
Copy link
Collaborator

openssl-machine commented Jan 17, 2026

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
@DDvO
util/ and .ctags.d/: remove remaining references to deleted util/chec…
85bc702 
…k-format.pl

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #29655)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
@DDvO
util/ and .ctags.d/: remove remaining references to deleted util/chec…
3047b40 
…k-format.pl

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #29655)

(cherry picked from commit 85bc702)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
@DDvO
util/ and .ctags.d/: remove remaining references to deleted util/chec…
9da3637 
…k-format.pl

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #29655)

(cherry picked from commit 85bc702)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
@DDvO
util/ and .ctags.d/: remove remaining references to deleted util/chec…
a2aed4a 
…k-format.pl

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #29655)

(cherry picked from commit 85bc702)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
@DDvO
util/ and .ctags.d/: remove remaining references to deleted util/chec…
1014627 
…k-format.pl

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #29655)

(cherry picked from commit 85bc702)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
@DDvO
util/ and .ctags.d/: remove remaining references to deleted util/chec…
81467a1 
…k-format.pl

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #29655)

(cherry picked from commit 85bc702)
@DDvO
Copy link
Contributor Author

DDvO commented Jan 19, 2026 •
edited
Loading

Merged to the changes to the active branches.
Was about to close this, but see below.

@DDvO
Copy link
Contributor Author

DDvO commented Jan 19, 2026

@quarckster et al., I just noticed further incompleteness of #29282:

  • an entry is missing in NEWS.md regarding the switch to clang-format.
  • also CONTRIBUTING.md still needs to be updated.

esyr pushed a commit to esyr/openssl that referenced this pull request Jan 19, 2026
@DDvO @esyr
util/ and .ctags.d/: remove remaining references to deleted util/chec…
19e7dbb 
…k-format.pl

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#29655)
@t8m
Copy link
Member

t8m commented Jan 20, 2026

Closing as any other changes need a new PR.

@t8m t8m closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

@esyr esyr esyr approved these changes

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DDvO @t8m @openssl-machine @levitte @esyr @paulidale