Closed
Conversation
The check for impacting a public api had an incorrect pattern in the search, leading to erroneous failures. Fix it up.
nhorman
added
branch: master
nhorman
force-pushed
the
fix-changes-test
branch
from
a4a4e2a to
3be7eee
Compare
nhorman
requested review from
Sashan,
andrewkdinh,
bob-beck,
esyr,
jogme,
levitte,
mattcaswell and
t8m
jogme
approved these changes
Jan 14, 2026
1 task
esyr
approved these changes
Jan 14, 2026
github-project-automation
bot
moved this from Waiting Review
to Waiting Merge
in Development Board
esyr
added
approval: done
andrewkdinh
approved these changes
Jan 14, 2026
2 tasks
paulidale
approved these changes
Jan 14, 2026
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
Author
|
merged to master, thank you |
github-project-automation
bot
moved this from Waiting Merge
to Done
in Development Board
openssl-machine
pushed a commit
that referenced
this pull request
Jan 15, 2026
The check for impacting a public api had an incorrect pattern in the search, leading to erroneous failures. Fix it up. Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> MergeDate: Thu Jan 15 17:14:30 2026 (Merged from #29636)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix search pattern in check-news-changes CI job
The check for impacting a public api had an incorrect pattern in the
search, leading to erroneous failures. Fix it up.
Checklist