Closed
Conversation
github-actions
bot
added
the
severity: ABI change
2 tasks
paulidale
previously approved these changes
Jan 14, 2026
paulidale
added
branch: master
mattcaswell
requested changes
Jan 15, 2026
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Looks good. One minor nit.
mattcaswell
approved these changes
Jan 15, 2026
beldmit
added
approval: done
paulidale
approved these changes
Jan 15, 2026
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
I didn't think the NIT fix was required but am happy with it.
t-j-h
approved these changes
Jan 16, 2026
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
t8m
approved these changes
Jan 16, 2026
Member
|
Merged to the master branch. Thank you @igus68 for fixing one of the oldest open issues! |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 16, 2026
Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Fri Jan 16 13:19:25 2026 (Merged from #29635)
esyr
pushed a commit
to esyr/openssl
that referenced
this pull request
Jan 19, 2026
Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> MergeDate: Fri Jan 16 13:19:25 2026 (Merged from openssl#29635)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1620
Checklist