Closed
Conversation
With our move to clang-format we no longer have a check-format script, and so this make target is broken. Fix it up to use clang-format-diff instead Fixes openssl#29594
nhorman
requested review from
Sashan,
andrewkdinh,
bob-beck,
esyr,
jogme,
levitte,
mattcaswell,
npajkovsky and
t8m
nhorman
added
branch: master
Sashan
reviewed
Jan 14, 2026
jogme
previously approved these changes
Jan 14, 2026
Contributor
jogme
left a comment
jogme
left a comment
There was a problem hiding this comment.
I think this is good enough. Thank you!
levitte
reviewed
Jan 14, 2026
jogme
previously approved these changes
Jan 15, 2026
jogme
added
approval: done
Sashan
previously approved these changes
Jan 15, 2026
Contributor
Sashan
left a comment
Sashan
left a comment
There was a problem hiding this comment.
still looks good, thanks.
levitte
requested changes
Jan 15, 2026
levitte
approved these changes
Jan 15, 2026
levitte
added
approval: review pending
Sashan
approved these changes
Jan 15, 2026
Contributor
Sashan
left a comment
Sashan
left a comment
There was a problem hiding this comment.
if Richard is happy, then I'm happy too.
Sashan
added
approval: done
paulidale
approved these changes
Jan 15, 2026
t-j-h
approved these changes
Jan 16, 2026
andrewkdinh
approved these changes
Jan 16, 2026
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
Author
|
merged to labeled branches, thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 16, 2026
With our move to clang-format we no longer have a check-format script, and so this make target is broken. Fix it up to use clang-format-diff instead Fixes #29594 Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Fri Jan 16 14:37:09 2026 (Merged from #29634) (cherry picked from commit 90d6c3b)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 16, 2026
With our move to clang-format we no longer have a check-format script, and so this make target is broken. Fix it up to use clang-format-diff instead Fixes #29594 Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Fri Jan 16 14:37:09 2026 (Merged from #29634)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 16, 2026
With our move to clang-format we no longer have a check-format script, and so this make target is broken. Fix it up to use clang-format-diff instead Fixes #29594 Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Fri Jan 16 14:37:09 2026 (Merged from #29634) (cherry picked from commit 90d6c3b)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 16, 2026
With our move to clang-format we no longer have a check-format script, and so this make target is broken. Fix it up to use clang-format-diff instead Fixes #29594 Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Fri Jan 16 14:37:09 2026 (Merged from #29634) (cherry picked from commit 90d6c3b)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 16, 2026
With our move to clang-format we no longer have a check-format script, and so this make target is broken. Fix it up to use clang-format-diff instead Fixes #29594 Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Fri Jan 16 14:37:09 2026 (Merged from #29634) (cherry picked from commit 90d6c3b)
esyr
pushed a commit
to esyr/openssl
that referenced
this pull request
Jan 19, 2026
With our move to clang-format we no longer have a check-format script, and so this make target is broken. Fix it up to use clang-format-diff instead Fixes openssl#29594 Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Fri Jan 16 14:37:09 2026 (Merged from openssl#29634)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With our move to clang-format we no longer have a check-format script, and so this make target is broken.
Fix it up to use clang-format-diff instead
Fixes #29594