Skip to content

Comments

Make OpenSSL generated error files use the current clang-format rules#29631

Closed
slontis wants to merge 2 commits intoopenssl:masterfrom
slontis:clang_format_generate_err_fixups
Closed

Make OpenSSL generated error files use the current clang-format rules#29631
slontis wants to merge 2 commits intoopenssl:masterfrom
slontis:clang_format_generate_err_fixups

Conversation

@slontis
Copy link
Member

@slontis slontis commented Jan 14, 2026

Anytime a new error code is added it generates error related files. These are generated using a perl script which used readable indenting. The indenting has been removed.

Checklist
  • documentation is added or updated
  • tests are added or updated

Anytime a new error code is added it generates error related files.
These are generated using a perl script which used readable indenting.
The indenting has been removed.
@slontis slontis added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Jan 14, 2026
@slontis
Copy link
Member Author

slontis commented Jan 14, 2026

The alternative to this would be to exclude *err.h and *_err.c files

@slontis slontis changed the title Make OpenSSL generated error files use the current clang-format. Make OpenSSL generated error files use the current clang-format rules Jan 14, 2026
@levitte levitte added approval: done This pull request has the required number of approvals triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly and removed approval: review pending This pull request needs review by a committer labels Jan 14, 2026
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 15, 2026
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
Anytime a new error code is added it generates error related files.
These are generated using a perl script which used readable indenting.
The indenting has been removed.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from #29631)
@slontis
Copy link
Member Author

slontis commented Jan 19, 2026

Merged to master, thanks for reviewing

@slontis slontis closed this Jan 19, 2026
@t8m t8m added the tests: exempted The PR is exempt from requirements for testing label Jan 19, 2026
esyr pushed a commit to esyr/openssl that referenced this pull request Jan 19, 2026
Anytime a new error code is added it generates error related files.
These are generated using a perl script which used readable indenting.
The indenting has been removed.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from openssl#29631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants