Closed
Conversation
Their semantics are poorly defined and they are rarely used. The _ne version being completely unused & tricky to define properly.
paulidale
added
branch: master
2 tasks
npajkovsky
approved these changes
Jan 14, 2026
fwh-dc
approved these changes
Jan 14, 2026
paulidale
added
approval: done
jogme
approved these changes
Jan 14, 2026
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
Author
|
Merged, thanks for the quick reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 15, 2026
Their semantics are poorly defined and they are rarely used. The _ne version being completely unused & tricky to define properly. Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Frederik Wedel-Heinen <[email protected]> (Merged from #29627)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 15, 2026
Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Frederik Wedel-Heinen <[email protected]> (Merged from #29627)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 15, 2026
Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> Reviewed-by: Frederik Wedel-Heinen <[email protected]> (Merged from #29627)
t8m
added
triaged: refactor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are rarely used and the _ne flavour is unused. Passing two lengths to a wrapper for
strncmp(3)makes defining semantics rather tricky (especially in the _ne case).Alternative to #29390