Add disabled-optimization and pointer-arith to compiler warnings#29622
Closed
mbroz wants to merge 1 commit intoopenssl:masterfrom
Closed
Add disabled-optimization and pointer-arith to compiler warnings#29622mbroz wants to merge 1 commit intoopenssl:masterfrom
mbroz wants to merge 1 commit intoopenssl:masterfrom
Conversation
These flags seems not to be part of -Wextra, but looks like could be useful in CI. According to gcc man page: disabled-optimization Warn if a requested optimization pass is disabled. pointer-arith Warn about anything that depends on the "size of" a function type or of "void". Fixes: openssl/project#1809 Signed-off-by: Milan Broz <[email protected]>
t8m
added
branch: master
t8m
approved these changes
Jan 13, 2026
esyr
approved these changes
Jan 13, 2026
esyr
added
approval: done
|
На 13.01.26 г. в 15:53, Milan Broz написа:
[SNIP]
pointer-arith
Warn about anything that depends on the "size of" a function type or of "void".
+ ... This warning is also enabled by -Wpedantic.
[SNIP]
Roumen
|
Member
Author
Right, missed that. But so are some other warnings in Configure (like switch or sign-compare). I would keep it as it is for now (as there will be more additions) and maybe later clean it - but it needs verification for all older compilers in CI. |
paulidale
approved these changes
Jan 13, 2026
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
jogme
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Jan 15, 2026
These flags seems not to be part of -Wextra, but looks like could be useful in CI. According to gcc man page: disabled-optimization Warn if a requested optimization pass is disabled. pointer-arith Warn about anything that depends on the "size of" a function type or of "void". Fixes: openssl/project#1809 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> MergeDate: Thu Jan 15 16:16:40 2026 (Merged from #29622)
Contributor
|
the change made it to master branch as commit f99eff70557 thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another trivia:
These flags seems not to be part of -Wextra, but looks like could be useful in CI. According to gcc man page:
disabled-optimization
Warn if a requested optimization pass is disabled.
pointer-arith
Warn about anything that depends on the "size of" a function type or of "void".
Fixes: openssl/project#1809
p.s.
note to myself: to check what is in -Wall and -Wextra for gcc, use
gcc -Wall -Wextra -Q --help=warnings