Adjust documentation of EVP_SKEY_import_raw_key#29546
Closed
beldmit wants to merge 3 commits intoopenssl:masterfrom
Closed
Adjust documentation of EVP_SKEY_import_raw_key#29546beldmit wants to merge 3 commits intoopenssl:masterfrom
beldmit wants to merge 3 commits intoopenssl:masterfrom
Conversation
beldmit
added
branch: master
mattcaswell
previously approved these changes
Jan 5, 2026
esyr
requested changes
Jan 6, 2026
Member
esyr
left a comment
esyr
left a comment
There was a problem hiding this comment.
Please harmonise the type of the key parameter in doc/designs/evp_skey.md.
paulidale
previously approved these changes
Jan 6, 2026
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
The comments should be addressed but that can be in a followup PR.
Or raise an issue noting them for future fixing.
paulidale
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Member
t8m
requested changes
Jan 8, 2026
t8m
approved these changes
Jan 12, 2026
Member
|
ping @paulidale @esyr for re-approval |
jogme
added
approval: review pending
esyr
added
approval: done
paulidale
approved these changes
Jan 15, 2026
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 19, 2026
Fixes #29509 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Mon Jan 19 14:12:01 2026 (Merged from #29546) (cherry picked from commit 3f4a593)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 19, 2026
Fixes #29509 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Mon Jan 19 14:12:01 2026 (Merged from #29546)
Member
|
Pushed to master, 3.6 and 3.5. Thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 19, 2026
Fixes #29509 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Paul Dale <[email protected]> MergeDate: Mon Jan 19 14:12:01 2026 (Merged from #29546) (cherry picked from commit 3f4a593)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29509
Checklist