Skip to content

Comments

fix: Fix uninstall_dev failing to remove empty dir#29472

Closed
Ra2-IFV wants to merge 1 commit intoopenssl:masterfrom
Ra2-IFV:fix_configure-uninstall-cmake
Closed

fix: Fix uninstall_dev failing to remove empty dir#29472
Ra2-IFV wants to merge 1 commit intoopenssl:masterfrom
Ra2-IFV:fix_configure-uninstall-cmake

Conversation

@Ra2-IFV
Copy link
Contributor

@Ra2-IFV Ra2-IFV commented Dec 20, 2025

Fix this error:

rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty

Because rmdir $PREFIX/lib64/cmake is missing

CLA: trivial

Checklist

Fix this error:
```
rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty
```
Because `rmdir $PREFIX/lib64/cmake` is missing

CLA: trivial
Signed-off-by: Ryan Keane <[email protected]>
Copy link
Contributor

@jogme jogme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

Agree with CLA trivial

@jogme jogme requested a review from t8m January 13, 2026 13:17
@t8m t8m added branch: master Applies to master branch branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Jan 13, 2026
@t8m t8m added the approval: done This pull request has the required number of approvals label Jan 13, 2026
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 14, 2026
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
Fix this error:
```
rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty
```
Because `rmdir $PREFIX/lib64/cmake` is missing

CLA: trivial
Signed-off-by: Ryan Keane <[email protected]>

Reviewed-by: Norbert Pocs <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Mon Jan 19 11:58:05 2026
(Merged from #29472)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
Fix this error:
```
rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty
```
Because `rmdir $PREFIX/lib64/cmake` is missing

CLA: trivial
Signed-off-by: Ryan Keane <[email protected]>

Reviewed-by: Norbert Pocs <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Mon Jan 19 11:58:05 2026
(Merged from #29472)

(cherry picked from commit da5d7f9)
@mattcaswell
Copy link
Member

Pushed to master, 3.6, 3.5, 3.4, and 3.3. thank you for the contribution.

openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
Fix this error:
```
rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty
```
Because `rmdir $PREFIX/lib64/cmake` is missing

CLA: trivial
Signed-off-by: Ryan Keane <[email protected]>

Reviewed-by: Norbert Pocs <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Mon Jan 19 11:58:05 2026
(Merged from #29472)

(cherry picked from commit da5d7f9)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
Fix this error:
```
rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty
```
Because `rmdir $PREFIX/lib64/cmake` is missing

CLA: trivial
Signed-off-by: Ryan Keane <[email protected]>

Reviewed-by: Norbert Pocs <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Mon Jan 19 11:58:05 2026
(Merged from #29472)

(cherry picked from commit da5d7f9)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2026
Fix this error:
```
rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty
```
Because `rmdir $PREFIX/lib64/cmake` is missing

CLA: trivial
Signed-off-by: Ryan Keane <[email protected]>

Reviewed-by: Norbert Pocs <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Mon Jan 19 11:58:05 2026
(Merged from #29472)

(cherry picked from commit da5d7f9)
esyr pushed a commit to esyr/openssl that referenced this pull request Jan 19, 2026
Fix this error:
```
rmdir "$PREFIX/lib64/cmake/OpenSSL"
rmdir "$PREFIX/lib64"
rmdir: failed to remove '$PREFIX/lib64': Directory not empty
```
Because `rmdir $PREFIX/lib64/cmake` is missing

CLA: trivial
Signed-off-by: Ryan Keane <[email protected]>

Reviewed-by: Norbert Pocs <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Mon Jan 19 11:58:05 2026
(Merged from openssl#29472)
@Ra2-IFV Ra2-IFV deleted the fix_configure-uninstall-cmake branch January 23, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants