Disable clang-format around this macro#29350
Closed
bob-beck wants to merge 1 commit intoopenssl:masterfrom
Closed
Conversation
clang-format sensibly thinks this is an arithmatic operation, and formats the math. Sadly it does not know we eventually stringify this behind several other layers of nested macros and so putting spaces in here is bad.
nhorman
added
branch: master
jogme
approved these changes
Dec 9, 2025
jogme
added
the
approval: ready to merge
Sashan
added
the
approval: done
github-actions
bot
added
the
severity: fips change
openssl-machine
pushed a commit
that referenced
this pull request
Dec 9, 2025
clang-format sensibly thinks this is an arithmatic operation, and formats the math. Sadly it does not know we eventually stringify this behind several other layers of nested macros and so putting spaces in here is bad. Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #29350)
Contributor
|
merged to master, 3.6, 3.5. Thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 9, 2025
clang-format sensibly thinks this is an arithmatic operation, and formats the math. Sadly it does not know we eventually stringify this behind several other layers of nested macros and so putting spaces in here is bad. Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #29350) (cherry picked from commit 5b0dffa)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 9, 2025
clang-format sensibly thinks this is an arithmatic operation, and formats the math. Sadly it does not know we eventually stringify this behind several other layers of nested macros and so putting spaces in here is bad. Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #29350) (cherry picked from commit 5b0dffa)
cxx194832
pushed a commit
to cxx194832/openssl
that referenced
this pull request
Dec 12, 2025
clang-format sensibly thinks this is an arithmatic operation, and formats the math. Sadly it does not know we eventually stringify this behind several other layers of nested macros and so putting spaces in here is bad. Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from openssl#29350)
Contributor
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format sensibly thinks this is an arithmatic operation, and formats the math. Sadly it does not know we eventually stringify this behind several other layers of nested macros and so putting spaces in here is bad.
Checklist