Skip to content

Comments

Fix array formatting in evp_extra_test.c#29349

Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell:fix-evpextra-arrays
Closed

Fix array formatting in evp_extra_test.c#29349
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell:fix-evpextra-arrays

Conversation

@mattcaswell
Copy link
Member

@mattcaswell mattcaswell commented Dec 9, 2025

The reformat did something silly with some of the arrays in evp_extra_test.c Fix the arrays such that clang-format is still happy.

@mattcaswell
Fix array formatting in evp_extra_test.c
4683712 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.
@mattcaswell mattcaswell added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly branch: 3.0 Applies to openssl-3.0 branch tests: exempted The PR is exempt from requirements for testing branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 labels Dec 9, 2025
bob-beck
bob-beck approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@bob-beck bob-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

probably the right way to consistently deal with this.

levitte
levitte approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is silliness indeed...

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 9, 2025
@loci-dev loci-dev mentioned this pull request Dec 9, 2025
Open
openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
@mattcaswell @nhorman
Fix array formatting in evp_extra_test.c
d54932c 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.

Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
(Merged from #29349)
openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
@mattcaswell @nhorman
Fix array formatting in evp_extra_test.c
2bdf560 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.

Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
(Merged from #29349)

(cherry picked from commit d54932c)
openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
@mattcaswell @nhorman
Fix array formatting in evp_extra_test.c
2d443c0 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.

Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
(Merged from #29349)

(cherry picked from commit d54932c)
openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
@mattcaswell @nhorman
Fix array formatting in evp_extra_test.c
0dc35ae 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.

Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
(Merged from #29349)

(cherry picked from commit d54932c)
openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
@mattcaswell @nhorman
Fix array formatting in evp_extra_test.c
5ee4005 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.

Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
(Merged from #29349)

(cherry picked from commit d54932c)
openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
@mattcaswell @nhorman
Fix array formatting in evp_extra_test.c
6b10af6 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.

Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
(Merged from #29349)

(cherry picked from commit d54932c)
@nhorman
Copy link
Contributor

nhorman commented Dec 9, 2025

merged to all active branches, thank you!

@nhorman nhorman closed this Dec 9, 2025
@mattcaswell
Copy link
Member Author

mattcaswell commented Dec 9, 2025

We seemed to have jumped the 24 hour gun here?

cxx194832 pushed a commit to cxx194832/openssl that referenced this pull request Dec 12, 2025
@mattcaswell @cxx194832
Fix array formatting in evp_extra_test.c
093d49b 
The reformat did something silly with some of the arrays in evp_extra_test.c
Fix the arrays such that clang-format is still happy.

Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
(Merged from openssl#29349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte approved these changes

@t8m t8m t8m approved these changes

@npajkovsky npajkovsky npajkovsky approved these changes

+1 more reviewer

@bob-beck bob-beck bob-beck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mattcaswell @nhorman @levitte @t8m @bob-beck @npajkovsky