Closed
Conversation
openssl-machine
added
the
hold: cla required
openssl-machine
removed
the
hold: cla required
2 tasks
ep69
force-pushed
the
fix-interop
branch
2 times, most recently
from
7a8385f to
6ab65f9
Compare
t8m
added
branch: master
nhorman
approved these changes
Dec 8, 2025
Contributor
Author
|
Please don't merge yet, it is not final and does not seem to work yet.. |
Contributor
Author
|
I am struggling with not being able to generate certificates with certgen. So far, it seems to me that something happened in openssl between commits c20d470 (good) and 55a0adf (bad). If somebody has clues what it might be, please let me know. I will continue looking into this tomorrow. Reproducer: # source /interop/Library/certgen/lib.sh && x509KeyGen ca && x509SelfSign ca
Using configuration from ca/ca.cnf
Check that the request matches the signature
Signature ok
The Subject's Distinguished Name is as follows
organizationName :ASN.1 12:'Example CA'
Segmentation fault (core dumped)
x509SelfSign: signing the certificate failed |
Contributor
|
@ep69 I see the problem, I'll have a PR for you shortly |
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Dec 8, 2025
We have a few cases in which one of the paramters passed to ASN1_TIME_diff is null (i.e. the caller doesn't care about the psec differnce and so passes NULL as that pointer parameter). However, OPENSSL_gmtime_diff assumes both pointers are valid, and so writes to them unilaterally resulting in a crash as observed here: openssl#29333 (comment) Check the pointers before writing to them.
Contributor
CLA: trivial
openssl-machine
added
the
hold: cla required
Contributor
Author
Contributor
Member
|
@ep69 could you please also file the ICLA? The corporate CLA already covers your contribuitons, but the individual one is still necessary |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 9, 2025
We have a few cases in which one of the paramters passed to ASN1_TIME_diff is null (i.e. the caller doesn't care about the psec differnce and so passes NULL as that pointer parameter). However, OPENSSL_gmtime_diff assumes both pointers are valid, and so writes to them unilaterally resulting in a crash as observed here: #29333 (comment) Check the pointers before writing to them. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> (Merged from #29337)
cxx194832
pushed a commit
to cxx194832/openssl
that referenced
this pull request
Dec 12, 2025
We have a few cases in which one of the paramters passed to ASN1_TIME_diff is null (i.e. the caller doesn't care about the psec differnce and so passes NULL as that pointer parameter). However, OPENSSL_gmtime_diff assumes both pointers are valid, and so writes to them unilaterally resulting in a crash as observed here: openssl#29333 (comment) Check the pointers before writing to them. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> (Merged from openssl#29337)
CLA: trivial
openssl-machine
removed
the
hold: cla required
t8m
added
the
approval: review pending
t8m
approved these changes
Dec 12, 2025
Member
t8m
left a comment
t8m
left a comment
There was a problem hiding this comment.
Note for merging - the drop! commit must be dropped.
nhorman
approved these changes
Dec 12, 2025
nhorman
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
|
merged to master with 2nd commit dropped. Thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2025
CLA: trivial Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #29333)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS interoperability tests need to be fixed now that engines are removed.
Checklist